Layout::Flex - Component implementation
#2751
Open
+1,440
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
didoo
force-pushed
the
flex-component-implementation
branch
from
363c966 to
240d50c
Compare
didoo
changed the title
Flex - Component implementationLayout::Flex - Component implementation
2 tasks
didoo
force-pushed
the
flex-component-implementation
branch
from
24bd31c to
757e032
Compare
didoo
force-pushed
the
flex-component-implementation
branch
from
c28eca6 to
566566c
Compare
dchyun
reviewed
Mar 18, 2025
There was a problem hiding this comment.
I think this is looking quite good overall. What do you think about adding @width and @height options though?
Or perhaps those could be considered together with break points & responsiveness in a phase 2 release? (I guess we already discussed doing these as a follow-on, sorry.)
shleewhite
reviewed
Mar 18, 2025
didoo
changed the title
Layout::Flex - Component implementationLayout::Flex - Component implementation
KristinLBradley
approved these changes
Mar 19, 2025
shleewhite
reviewed
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
This PR implements the
Flexcomponent (HDS-4531) in the context of the wider initiative for spacing/layout/pages components/helpers (HDS-4527).There is an equivalent PR to implement a grid component: #2756
🛠️ Detailed description
In this PR I have:
Hds::Layout::FlexcomponentFlexThe component documentation is done in #2764
👉 👉 👉 Preview: https://hds-showcase-git-flex-component-implementation-hashicorp.vercel.app/layouts/flex
🔗 External links
Jira ticket: https://hashicorp.atlassian.net/browse/HDS-4635
Project plan: HDS Project Plan - Flex/Grid components
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.